Skip to content

Conversation

@ellemouton
Copy link
Member

@ellemouton ellemouton commented Nov 9, 2024

Allow --network=signet

Copy link
Contributor

@guggero guggero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK, LGTM 🎉

Copy link

@dstadulis dstadulis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK on 850e6fa

Are any release notes helpful to caveat signet performance with the liquidity-service for Loop/Pool etc?

Copy link
Contributor

@ViktorT-11 ViktorT-11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK LGTM 🚀!

We have this issue for regtest as well:
But should we mention somewhere that autopilot should be disabled if running on signet, as we don't support it on the autopilot server yet?
Maybe that's better suited for docs.lightning.engineering though.

@ellemouton
Copy link
Member Author

Maybe that's better suited for docs.lightning.engineering though.

Yeah i think that is ok. Cause LiT will already throw an error if a user tries to spin up LiT on regtest/signet with autopilot enabled

@ellemouton ellemouton merged commit 4d0f343 into lightninglabs:master Nov 19, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

4 participants